Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/t2000-wreck.t: Fix invalid compare on 'wreckrun: --input=0 works' test #836

Merged
merged 1 commit into from Oct 7, 2016

Conversation

Projects
None yet
5 participants
@chu11
Copy link
Contributor

chu11 commented Oct 7, 2016

I don't have the test framework's code/internals fully understood yet, but this didn't look right. Outputs are named output.1 and expected.1, but we're comparing output.0 and expected.1?

@garlick garlick added the review label Oct 7, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 7, 2016

Coverage Status

Coverage decreased (-0.02%) to 75.326% when pulling 1bbe947 on chu11:t2000-wreck.t-bad-test_cmp into dc58fcb on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 7, 2016

Current coverage is 75.01% (diff: 100%)

Merging #836 into master will decrease coverage by 0.02%

@@             master       #836   diff @@
==========================================
  Files           146        146          
  Lines         25415      25415          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          19071      19065     -6   
- Misses         6344       6350     +6   
  Partials          0          0          

Powered by Codecov. Last update dc58fcb...1bbe947

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 7, 2016

Good catch! That would have allowed errors to slip through without being caught.

Thanks!

@grondo grondo merged commit c94fdd3 into flux-framework:master Oct 7, 2016

4 checks passed

codecov/patch Coverage not affected when comparing dc58fcb...1bbe947
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +24.96% compared to dc58fcb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 75.326%
Details

@grondo grondo removed the review label Oct 7, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.