Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pointer from typedef flux_t #841

Merged
merged 1 commit into from Oct 11, 2016

Conversation

Projects
None yet
4 participants
@morrone
Copy link
Contributor

morrone commented Oct 11, 2016

Remove the pointer from the definition of the typedef
flux_t to comply with the Coding Style Guide.

Fixes #840

Remove pointer from typedef flux_t
Remove the pointer from the definition of the typedef
flux_t to comply with the Coding Style Guide.

Fixes #840
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 11, 2016

Coverage Status

Coverage decreased (-0.02%) to 75.334% when pulling 9208b51 on morrone:flux_t_pointer into 2df89fd on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 11, 2016

Current coverage is 75.02% (diff: 85.37%)

Merging #841 into master will decrease coverage by 0.02%

@@             master       #841   diff @@
==========================================
  Files           146        146          
  Lines         25415      25415          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          19075      19068     -7   
- Misses         6340       6347     +7   
  Partials          0          0          
Diff Coverage File Path
0% src/cmd/flux-up.c
0% src/common/libcompat/info.c
0% src/modules/live/liblive.c
0% src/common/libflux/module.c
0% src/common/libflux/panic.c
0% src/common/libsubprocess/subprocess.c
•••• 42% src/broker/modservice.c
••••• 50% src/modules/live/live.c
••••• 50% src/common/libcompat/request.c
••••• 50% src/common/libflux/reparent.c

Review all 73 files changed

Powered by Codecov. Last update 2df89fd...9208b51

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 11, 2016

Thank you! Merging.

@garlick garlick merged commit ec5bfdd into flux-framework:master Oct 11, 2016

4 checks passed

codecov/patch 85.37% of diff hit (target 75.05%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +10.32% compared to 2df89fd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 75.334%
Details

@garlick garlick removed the review label Oct 11, 2016

@morrone morrone deleted the morrone:flux_t_pointer branch Oct 11, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.