Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make distcheck #847

merged 2 commits into from Oct 13, 2016


None yet
5 participants
Copy link

chu11 commented Oct 12, 2016

Per discussion in #842

chu11 added some commits Oct 10, 2016

src/bindings/lua/ Fix duplicate dist of files
Listing of directories in EXTRA_DIST lead to duplicate dist of files,
leading to failure of distcheck. Handle corner case with PYTHON_LDFLAGS
If Python libraries are installed in a standard path (e.g. /usr/lib64),
linking problems can occur if PYTHON_LDFLAGS sets -L and moves the
standard path earlier in the linker search.

If the Python libdir is standard, remove it from PYTHON_LDFLAGS.

@garlick garlick added the review label Oct 12, 2016


This comment has been minimized.

Copy link

coveralls commented Oct 12, 2016

Coverage Status

Coverage decreased (-0.04%) to 75.101% when pulling 819796d on chu11:fixdistcheck into 286b6e7 on flux-framework:master.


This comment has been minimized.

Copy link

codecov-io commented Oct 12, 2016

Current coverage is 71.54% (diff: 100%)

Merging #847 into master will increase coverage by 0.02%

@@             master       #847   diff @@
  Files           157        157          
  Lines         26688      26688          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
+ Hits          19087      19093     +6   
+ Misses         7601       7595     -6   
  Partials          0          0          

Powered by Codecov. Last update 286b6e7...819796d


This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 12, 2016

known jsc fail in travis, rebuild appears to have passed


grondo approved these changes Oct 12, 2016

Copy link

grondo left a comment

Thanks, this looks good! Sorry about laziness under bindings/lua.

@grondo grondo merged commit d4a67ce into flux-framework:master Oct 13, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 286b6e7...819796d
codecov/project 71.54% (+0.02%) compared to 286b6e7
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage decreased (-0.04%) to 75.101%

@grondo grondo removed the review label Oct 13, 2016

@chu11 chu11 referenced this pull request Oct 13, 2016


make distcheck failing #842

@garlick garlick referenced this pull request Oct 26, 2016


0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.