Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output errors with flux up --comma & --newline, add appropriate tests #858

Merged
merged 2 commits into from Oct 19, 2016

Conversation

Projects
None yet
5 participants
@chu11
Copy link
Contributor

chu11 commented Oct 18, 2016

No description provided.

@garlick garlick added the review label Oct 18, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 18, 2016

Coverage Status

Coverage increased (+0.05%) to 75.156% when pulling cddea1c on chu11:fluxupfixes into 1d3081d on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 18, 2016

Current coverage is 71.58% (diff: 100%)

Diff Coverage File Path
•••••••••• 100% src/cmd/flux-up.c

No coverage report found for master at 18ae697.

Powered by Codecov. Last update 18ae697...fddc311

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 18, 2016

Nice work and 100% coverage in the diff 👍

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 19, 2016

Want to rebase after #811 and I'll merge?

chu11 added some commits Oct 18, 2016

src/cmd/flux-up.c: Fix output error
When using --newline or --comma, ranges were improperly surrounded
by brackets.
t/t0010-generic-utils.t: Add tests
Add tests for flux-up --comma and --newline

@chu11 chu11 force-pushed the chu11:fluxupfixes branch from cddea1c to fddc311 Oct 19, 2016

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 19, 2016

@garlick sure thing, pushed a rebased version, it's going through travis now

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 19, 2016

Coverage Status

Changes Unknown when pulling fddc311 on chu11:fluxupfixes into * on flux-framework:master*.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 19, 2016

Thanks!

@garlick garlick merged commit e4a3eac into flux-framework:master Oct 19, 2016

4 checks passed

codecov/patch 100% of diff hit (target 71.58%)
Details
codecov/project 71.58% (+0.03%) compared to f3c33ef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 75.196%
Details

@garlick garlick removed the review label Oct 19, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.