Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsc test: Add timed waits to avoid races #859

Merged
merged 1 commit into from Oct 19, 2016

Conversation

Projects
None yet
5 participants
@dongahn
Copy link
Contributor

dongahn commented Oct 19, 2016

Add a timed wait on a job-state pattern to allow flux-jstat
to receive all of the job events within up to 2 seconds.

If and when a wreck.state.* event is delayed to be received
by "flux-jstat notify" used in some subtests,
they can end up prematurely comparing the result
against incomplete jstat outputs.

A timed wait helps avoid such false alarms. Resolve #512.

jsc test: Add timed waits to avoid races
Add a timed wait on a job-state pattern to allow flux-jstat
to receive all of the job events within up to 2 seconds.

If and when a wreck.state.* event is delayed to be received
by "flux-jstat notify" used in some subtests,
they can end up prematurely comparing the result
against incomplete jstat outputs.

A timed wait helps avoid such false alarms. Resolve #512.

@garlick garlick added the review label Oct 19, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 19, 2016

Coverage Status

Coverage decreased (-0.01%) to 75.097% when pulling 35f0811 on dongahn:jsc_test_timed_wait into 1d3081d on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 19, 2016

Current coverage is 71.47% (diff: 100%)

Merging #859 into master will decrease coverage by 0.01%

@@             master       #859   diff @@
==========================================
  Files           157        157          
  Lines         26683      26683          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          19075      19072     -3   
- Misses         7608       7611     +3   
  Partials          0          0          

Powered by Codecov. Last update 1d3081d...35f0811

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 19, 2016

Thanks @dongahn! Merging!

@grondo grondo merged commit 402ee49 into flux-framework:master Oct 19, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 1d3081d...35f0811
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +28.51% compared to 1d3081d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 75.097%
Details

@grondo grondo removed the review label Oct 19, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.