Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc minor fixes #862

Merged
merged 9 commits into from Oct 21, 2016

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Oct 20, 2016

This PR contains an assortment of minor fixes:

  • fix errors in a test that isn't run automatically (due to trickiness setting up munge in test environment)
  • silence warnings
  • add a small bit of test coverage
  • improve proxy test that was found to be brittle with respect to /tmp contents

garlick added some commits Oct 4, 2016

test/kvs: add coverage for base64 encoded kvs data
Exercise these flux-kvs functions that lacked coverage:
   flux kvs copy-fromkvs
   flux kvs copy-tokvs
modules/kvs: avoid internal use of deprecated api
Rearange code internally to avoid the following warning:

libkvs.c: In function ‘kvs_watch_once’:
libkvs.c:810:5: warning: ‘kvs_watch_once_obj’ is deprecated
modules/libjsc: avoid internal use of deprecated api
Rearange code internally to avoid the following warnings:

jstatctl.c: In function ‘jsc_notify_status’:
jstatctl.c:1094:5: warning: ‘jsc_notify_status_obj’ is deprecated

jstatctl.c: In function ‘jsc_query_jcb’
jstatctl.c:1137:5: warning: ‘jsc_query_jcb_obj’ is deprecated

jstatctl.c: In function ‘jsc_update_jcb’:
jstatctl.c:1189:5: warning: ‘jsc_update_jcb_obj’ is deprecated
test/tmunge: fix misc. errors in test
This test is not run by any of our automated infrastructure.
A quick test on hype revealed several problems, fixed here:
- invalid json payload (not causing a problem though)
- incorrect parenthesis in test for correct number of frames
- number of frames expected is 4 not 2 (proto+topic+json+delim)
modules/kvs: fix typo in kvsdir_key_at()
A typo in the kvsdir_key_at() implementation was causing a
clang-3.8 warning.  Tidy up the function.

Fixes #861

@garlick garlick added the review label Oct 20, 2016

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 20, 2016

Current coverage is 72.17% (diff: 47.05%)

Merging #862 into master will increase coverage by 0.35%

@@             master       #862   diff @@
==========================================
  Files           156        156          
  Lines         26932      26955    +23   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          19343      19456   +113   
+ Misses         7589       7499    -90   
  Partials          0          0          
Diff Coverage File Path
•••• 45% src/common/libflux/security.c
••••• 50% src/modules/kvs/libkvs.c
••••• 50% src/modules/libjsc/jstatctl.c

Powered by Codecov. Last update 62c69e1...d7f4a3c

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 20, 2016

Coverage Status

Coverage increased (+0.1%) to 75.546% when pulling 0182beb on garlick:misc_fixes into 62c69e1 on flux-framework:master.

garlick added some commits Oct 21, 2016

libflux/security: add FLUX_SEC_TYPE_FAKEMUNGE flag
Allow tests to work around the difficulty in setting up
munge for testing.  If the FLUX_SEC_TYPE_FAKEMUNGE flag
is set in the security context, simply base64 encode/decode
payload.
test/munge: add tmunge --fake option
If --fake is used, set the FLUX_SEC_TYPE_FAKEMUNGE flag
to tell security module to work around unconfigured munge.
test/security: add security sharness test
Initially this test just ensures the pathways for encoding/
decoding EPGM with munge are working.
@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Oct 21, 2016

It bugged me that tmunge was not ever getting run, and thus the refactoring of epgm munging just merged in #857 was not getting tested at all. So just added some commits to allow those paths to be tested without having munge configured.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2016

Coverage Status

Coverage increased (+0.4%) to 75.791% when pulling d7f4a3c on garlick:misc_fixes into 62c69e1 on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 21, 2016

Nicely done!

@grondo grondo merged commit 579e4ff into flux-framework:master Oct 21, 2016

3 of 4 checks passed

codecov/patch 47.05% of diff hit (target 71.82%)
Details
codecov/project 72.17% (+0.35%) compared to 62c69e1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 75.791%
Details

@grondo grondo removed the review label Oct 21, 2016

@garlick garlick deleted the garlick:misc_fixes branch Oct 21, 2016

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.