Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis-ci: minor updates #865

Merged
merged 3 commits into from Oct 24, 2016

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Oct 21, 2016

Some minor cleanup and fixes for Travis:

  • Fix a few bugs in backtrace-all.sh to clean up spurious errors and allow backtrace of executables in $PATH (e.g. /usr/bin/lua)
  • Remove libjson-c build, it is built-in to flux-core now
  • Pull in munge as a package since it is now whitelisted
  • Do not perform multiple builds on coverity_scan branch

grondo added some commits Oct 19, 2016

travis-ci: update build requirements
Remove libjson-c and munge from travis-dep-builder.sh.

Add libmunge-dev to apt packages to install with travis.
test: backtrace-all.sh: fix backtrace for exec in PATH
When executable causing backtrace is in PATH, and thus doesn't have
a relative or absolute path recorded in the corefile, the
backtrace-all script would fail to list a backtrace because
`test -x $exe` was failing. Precede the check with a `which $exe`
to translate an executable name to a path.

Also, quote around '*.core' in case there are one or more corefiles
in the current directory.
travis-ci: do not run coverity-scan for every build target
Avoid running coverity scan on every matrix build, just run once.

Also, there is no need to run the regular build after a scan
is complete, so short circuit that as well in the beginning of script:.

@grondo grondo added the review label Oct 21, 2016

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 21, 2016

Current coverage is 72.15% (diff: 100%)

Merging #865 into master will increase coverage by 0.04%

@@             master       #865   diff @@
==========================================
  Files           156        156          
  Lines         26955      26955          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          19437      19449    +12   
+ Misses         7518       7506    -12   
  Partials          0          0          

Powered by Codecov. Last update 579e4ff...a15f242

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2016

Coverage Status

Coverage increased (+0.05%) to 75.764% when pulling a15f242 on grondo:travis-refresh into 579e4ff on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 24, 2016

Great! Thanks, merging.

@garlick garlick merged commit f845160 into flux-framework:master Oct 24, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 579e4ff...a15f242
Details
codecov/project 72.15% (+0.04%) compared to 579e4ff
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 75.764%
Details

@garlick garlick removed the review label Oct 24, 2016

This was referenced Oct 24, 2016

@grondo grondo deleted the grondo:travis-refresh branch Nov 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.