Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to verify KVS int can be read as double #878

Merged
merged 2 commits into from Oct 26, 2016

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Oct 26, 2016

This PR adds a test program t/kvs/getas and a new test in t1000-kvs-basic.t to make sure the fix @SteVwonder added in #872 stays fixed.

garlick added some commits Oct 26, 2016

test/kvs: add kvs/getas test program
Add test program that allows each of the typed kvs_get
and kvsdir_get variants to be used from the command line.
test/kvs: test int can be read as double
Add a test that ensures an int KVS value can be read back with

kvs_get_int()
kvs_get_int64()
kvs_get_double()
kvsdir_get_int()
kvsdir_get_int64()
kvsdir_get_double()

Fixes #875

@garlick garlick added the review label Oct 26, 2016

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 26, 2016

Nicely done! Thanks!

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 26, 2016

Coverage Status

Coverage increased (+0.1%) to 75.82% when pulling 3a6b389 on garlick:kvsdouble into 11bb1a2 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 26, 2016

Current coverage is 72.20% (diff: 100%)

Merging #878 into master will increase coverage by 0.13%

@@             master       #878   diff @@
==========================================
  Files           156        156          
  Lines         26947      26947          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          19420      19457    +37   
+ Misses         7527       7490    -37   
  Partials          0          0          

Powered by Codecov. Last update 11bb1a2...3a6b389

@grondo grondo merged commit f79d5cc into flux-framework:master Oct 26, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 11bb1a2...3a6b389
Details
codecov/project 72.20% (+0.13%) compared to 11bb1a2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 75.82%
Details

@grondo grondo removed the review label Oct 26, 2016

@garlick garlick deleted the garlick:kvsdouble branch Oct 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.