Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barrier module cleanup and debug logging #885

Merged
merged 3 commits into from Oct 28, 2016

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Oct 27, 2016

This switches the barrier module over to the new JSON payload encode/decode functions and adds some debugging log messages to help track down hung barriers.

@garlick garlick added the review label Oct 27, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 28, 2016

Coverage Status

Coverage decreased (-0.06%) to 75.777% when pulling 6829c17 on garlick:barrier_debug into e98c4aa on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 28, 2016

Current coverage is 72.16% (diff: 80.00%)

Merging #885 into master will decrease coverage by 0.02%

@@             master       #885   diff @@
==========================================
  Files           156        156          
  Lines         26945      26929    -16   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          19451      19433    -18   
- Misses         7494       7496     +2   
  Partials          0          0          
Diff Coverage File Path
••••••• 78% src/modules/barrier/barrier.c
•••••••••• 100% src/modules/barrier/libbarrier.c

Powered by Codecov. Last update abfc25b...94417a7

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 28, 2016

This seems reasonable to pull in before tag of v0.5.0. What do you think @garlick?

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Oct 28, 2016

Sure, let me get it rebased and once it is merged I can update the release notes PR.

garlick added some commits Oct 27, 2016

modules/barrier: add debug log messages
Add some debug code to the barrier module so that
barrier creation and completion is logged, and set a
timer to fire after 1s, and repeat every 1s after that,
which logs how many procs are outstanding.

This is always enabled, since it should be pretty
low overhead.
module/barrier: use jansson functions
Clean up barrier implementation by using new varargs functions
for JSON payload encode/decode.

@garlick garlick force-pushed the garlick:barrier_debug branch from 6829c17 to 94417a7 Oct 28, 2016

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Oct 28, 2016

OK, rebased on current master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 28, 2016

Coverage Status

Coverage decreased (-0.03%) to 75.777% when pulling 94417a7 on garlick:barrier_debug into abfc25b on flux-framework:master.

@grondo grondo merged commit 02dd878 into flux-framework:master Oct 28, 2016

4 checks passed

codecov/patch 80.00% of diff hit (target 72.18%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +7.81% compared to abfc25b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 75.777%
Details

@grondo grondo removed the review label Oct 28, 2016

@chu11 chu11 referenced this pull request Oct 31, 2016

Closed

t0010-generic-utils.t hang #888

@garlick garlick deleted the garlick:barrier_debug branch Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.