Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor cleanup and documentation updates #886

Merged
merged 6 commits into from Oct 28, 2016

Conversation

Projects
None yet
5 participants
@chu11
Copy link
Contributor

chu11 commented Oct 28, 2016

Of particular review interest, commit b4fca3e documents flux-wreckrun environment variables. Hopefully I got resource manager lingo correct.

chu11 added some commits Oct 27, 2016

Add SEE ALSO info to manpages
Add flux-wreck(1) to SEE ALSO for flux-wreckrun(1)
Add flux-wreckrun(1) to SEE ALSO for flux-wreck(1)
doc/man1/flux-wreckrun.adoc: lwj hierarchy updates
Update manpage text to be aware of lwj hierarchy configuration.
Note use of 'flux wreck last-jobid -p' to determine full directory path.
doc/man1/flux-wreck.adoc: Add missing options
Document kvs-path subcommand.
Document --kvs-path option for last-jobid command.
src/cmd/flux-wreck: Make help output consistent
For consistency to other options in flux-wreck, make option to
kvs-path subcommand JOBID instead of ID.
doc/man1/flux-wreckrun.adoc: Add environment info
Add list and description of environment variables provided by
flux-wreckrun to tasks.

@garlick garlick added the review label Oct 28, 2016

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 28, 2016

Current coverage is 72.18% (diff: 0.00%)

Merging #886 into master will decrease coverage by 0.02%

@@             master       #886   diff @@
==========================================
  Files           156        156          
  Lines         26945      26945          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          19459      19451     -8   
- Misses         7486       7494     +8   
  Partials          0          0          
Diff Coverage File Path
0% src/cmd/flux.c

Powered by Codecov. Last update e98c4aa...b4fca3e

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 28, 2016

Coverage Status

Coverage decreased (-0.03%) to 75.807% when pulling b4fca3e on chu11:minorcleanups2 into e98c4aa on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 28, 2016

I suspect code coverage failure is code coverage not hitting my typo fix in the log message error.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 28, 2016

I suspect code coverage failure is code coverage not hitting my typo fix in the log message error.

Yeah, that is why code coverage checks are not required, just advisory at this point. Maybe someday GitHub will allow them to be warnings, but right now I think it is pass/fail.

These are good fixes and I think we should get them in before we tag. Anything else pending for this PR @chu11?

@grondo grondo merged commit abfc25b into flux-framework:master Oct 28, 2016

2 of 4 checks passed

codecov/patch 0.00% of diff hit (target 72.21%)
Details
codecov/project 72.18% (-0.03%) compared to e98c4aa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 75.807%
Details

@grondo grondo removed the review label Oct 28, 2016

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 28, 2016

Eh, seemed complete so I went ahead and merged. We'll try to tag v0.5.0 today perhaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.