Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: install kz bindings file #895

Merged
merged 2 commits into from Nov 28, 2016

Conversation

Projects
None yet
5 participants
@trws
Copy link
Member

trws commented Nov 3, 2016

The kz bindings have been getting built, but their native interface file
was not being installed. This fixes that issue.

Fixes flux-framework/capacitor#6

@garlick garlick added the review label Nov 3, 2016

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Nov 10, 2016

@trws, this PR failed in travis with

make[4]: *** No rule to make target `kz.py', needed by `distdir'.  Stop.
make[4]: Leaving directory `/home/travis/build/flux-framework/flux-core/src/bindings/python/flux'
make[3]: *** [distdir] Error 1
make[3]: Leaving directory `/home/travis/build/flux-framework/flux-core/src/bindings/python'
make[2]: *** [distdir] Error 1
make[2]: Leaving directory `/home/travis/build/flux-framework/flux-core/src/bindings'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/home/travis/build/flux-framework/flux-core/src'
make: *** [distdir] Error 1

I can try to diagnose further if you like (maybe a builddir v srcdir thing?) We also need to rebase on master. We probably want to get this in and tag v0.5.1, since I assume capacitor wouldn't work right now against our 0.5.0 package?

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 22, 2016

Coverage Status

Coverage increased (+0.3%) to 76.156% when pulling 4946fe3 on trws:install-kz-bindings into e8f8968 on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Nov 23, 2016

One or more python tests are now failing here, sorry I'm not much help beyond cut-and-paste though:

Traceback (most recent call last):
  File "../../src/bindings/python/test_commands/test_runner.t", line 54, in <module>
    run_under_dir(result_set, '../flux', 'flux')
  File "../../src/bindings/python/test_commands/test_runner.t", line 29, in run_under_dir
    (mod_prefix, m.group(1))))
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/travis/build/flux-framework/flux-core/flux-core-0.5.0-116-g1919937/_build/src/bindings/python/flux/kz.py", line 4, in <module>
    import flux.json_c as json_c
ImportError: No module named json_c
FAIL: ../t/t9990-python-tests.t

@trws

This comment has been minimized.

Copy link
Member Author

trws commented Nov 23, 2016

I'm looking into what's going on here, but it's quite strange, the
changes in this branch don't actually introduce anything to that test
other than a module that shouldn't be loaded at that point. It's taking
me a bit to track down why this is happening.

On 23 Nov 2016, at 14:41, Mark Grondona wrote:

One or more python tests are now failing here, sorry I'm not much help
beyond cut-and-paste though:

Traceback (most recent call last):
  File "../../src/bindings/python/test_commands/test_runner.t", line 
54, in <module>
    run_under_dir(result_set, '../flux', 'flux')
  File "../../src/bindings/python/test_commands/test_runner.t", line 
29, in run_under_dir
    (mod_prefix, m.group(1))))
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in 
import_module
    __import__(name)
  File 
"/home/travis/build/flux-framework/flux-core/flux-core-0.5.0-116-g1919937/_build/src/bindings/python/flux/kz.py", 
line 4, in <module>
    import flux.json_c as json_c
ImportError: No module named json_c
FAIL: ../t/t9990-python-tests.t

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#895 (comment)

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Nov 23, 2016

It's taking me a bit to track down why this is happening.

Ah, my apologies. Let me know if you need any assistance.

@trws trws force-pushed the trws:install-kz-bindings branch from 4946fe3 to cdbb10b Nov 28, 2016

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 28, 2016

Current coverage is 75.86% (diff: 100%)

Merging #895 into master will increase coverage by <.01%

@@             master       #895   diff @@
==========================================
  Files           149        149          
  Lines         25999      25999          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          19721      19723     +2   
+ Misses         6278       6276     -2   
  Partials          0          0          

Powered by Codecov. Last update dbfcf2a...01d46f6

trws added some commits Nov 3, 2016

python: install kz bindings file
The kz bindings have been getting built, but their native interface file
was unavailable.  This fixes that issue.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 28, 2016

Coverage Status

Coverage decreased (-0.01%) to 76.134% when pulling cdbb10b on trws:install-kz-bindings into dbfcf2a on flux-framework:master.

@trws trws force-pushed the trws:install-kz-bindings branch from cdbb10b to 01d46f6 Nov 28, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 28, 2016

Coverage Status

Coverage increased (+0.007%) to 76.156% when pulling 01d46f6 on trws:install-kz-bindings into dbfcf2a on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Nov 28, 2016

@trws, looks good now! Ready to merge?

@trws

This comment has been minimized.

Copy link
Member Author

trws commented Nov 28, 2016

Good to go. 👍

@grondo grondo merged commit e4d3cc0 into flux-framework:master Nov 28, 2016

4 checks passed

codecov/patch Coverage not affected when comparing dbfcf2a...01d46f6
Details
codecov/project 75.86% (+<.01%) compared to dbfcf2a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 76.156%
Details

@grondo grondo removed the review label Nov 28, 2016

@grondo grondo referenced this pull request Nov 28, 2016

Closed

Create 0.6.0 release notes #916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.