Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker: adjust errno response to "upstream" request on rank 0 #913

Merged
merged 3 commits into from Nov 21, 2016

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Nov 21, 2016

This PR simply changes an inappropriate errno response of ENOSYS to EHOSTUNREACH when a message reaches the rank 0 broker that was from rank 0 and has the FLUX_MSGFLAG_UPSTREAM message flag set.

It also modifies flux-ping to display the rank!service that elicited the error.

garlick added some commits Nov 21, 2016

broker: return EHOSTUNREACH on upstream from rank0
Problem: a request sent from rank 0 with the
FLUX_MSGFLAG_UPSTREAM flag set receives an ENOSYS
resopnse from the rank 0 broker.

Change the response in this case to EHOSTUNREACH.

Fixes #912
cmd/flux-ping: print rank!topic in error message
Instead of printing e.g.
  $ flux ping upstream cmb
  flux-ping: flux_rpc_getf: No route to host

print the rank and topic string, e.g.
  flux-ping: upstream!cmb.ping: No route to host

@garlick garlick added the review label Nov 21, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 21, 2016

Coverage Status

Coverage decreased (-0.0009%) to 76.12% when pulling 0ac59e4 on garlick:issue_912 into 55c99a3 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 21, 2016

Current coverage is 72.52% (diff: 66.66%)

Merging #913 into master will increase coverage by <.01%

@@             master       #913   diff @@
==========================================
  Files           159        159          
  Lines         27162      27162          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          19699      19700     +1   
+ Misses         7463       7462     -1   
  Partials          0          0          
Diff Coverage File Path
••••• 50% src/broker/broker.c
•••••••••• 100% src/cmd/flux-ping.c
•••••••••• 100% src/broker/overlay.c

Powered by Codecov. Last update 55c99a3...0ac59e4

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Nov 21, 2016

Looks good, merging.

@grondo grondo merged commit 43cc545 into flux-framework:master Nov 21, 2016

3 of 4 checks passed

codecov/patch 66.66% of diff hit (target 72.52%)
Details
codecov/project 72.52% (+<.01%) compared to 55c99a3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0009%) to 76.12%
Details

@grondo grondo removed the review label Nov 21, 2016

@garlick garlick deleted the garlick:issue_912 branch Nov 21, 2016

@grondo grondo referenced this pull request Nov 28, 2016

Closed

Create 0.6.0 release notes #916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.