Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor KVS cleanup #919

Merged
merged 8 commits into from Dec 10, 2016

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Dec 9, 2016

Collection of minor fixes, updates, etc. from a larger branch dealing with #897

chu11 added some commits Dec 2, 2016

test/kvs: Add dropcache tests
Add missing dropcache and dropcache-all tests
cmd/flux-kvs: Refactor cleanup
Create common output function for 'get' and dump functions.
cmd/flux-kvs: Refactor cleanup
Use common output functions for outputting results from
kvs_get() and similar calls.
cmd/flux-kvs: Add missing options in usage
Update usage with -d option with appropriate commands.

@garlick garlick added the review label Dec 9, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2016

Coverage Status

Coverage increased (+0.1%) to 76.279% when pulling ac461fc on chu11:kvscleanup1 into 2253404 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 9, 2016

Current coverage is 75.97% (diff: 88.46%)

Merging #919 into master will increase coverage by 0.07%

@@             master       #919   diff @@
==========================================
  Files           149        149          
  Lines         25999      26001     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          19735      19755    +20   
+ Misses         6264       6246    -18   
  Partials          0          0          
Diff Coverage File Path
•••••••• 88% src/cmd/flux-kvs.c

Powered by Codecov. Last update 2253404...ac461fc

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 10, 2016

This looks good to me. Ready to merge?

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Dec 10, 2016

Yup, these are all minor patches.

@garlick garlick merged commit 99a6800 into flux-framework:master Dec 10, 2016

4 checks passed

codecov/patch 88.46% of diff hit (target 75.90%)
Details
codecov/project 75.97% (+0.07%) compared to 2253404
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 76.279%
Details

@garlick garlick removed the review label Dec 10, 2016

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.