Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a pkg-config package for Flux PMI #921

Merged
merged 2 commits into from Dec 13, 2016

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Dec 13, 2016

This PR adds a pkg-config package for Flux's libpmi.so in support of an OpenMPI "flux" component under discussion in rhc54/ompi#1.

libpmi.so is purposefully excluded from flux-core's pkg-config package because in general we want the selection of a PMI library to be a runtime decision. The new component will normally try to dlopen our library at $FLUX_PMI_LIBRARY_PATH. However in cases where OpenMPI builds all its modules statically (apparently common on big systems), dlopen is not permitted and it needs to find our libpmi.so at build time. Using pkg-config for this avoids hard wiring a search heuristic in the configuration m4sh for the flux component.

Unrelated fix to a silly output typo in a PMI test program is tacked on here as well.

garlick added some commits Dec 7, 2016

build: add flux-pmi.pc
Add a pkg-config file for libpmi.so that allows a future
openmpi mca for flux to link against it without complex
autoconf m4.

The mca in development dlopens the library path from
FLUX_PMI_LIBRARY_PATH environment variable by default,
but may be built against a specific Flux library path
in the case where openmpi is being built with --enable-static
or --disable-dlopen, apparently common on large clusters.

Discussed in rhc54/ompi#1
test/pmi: fix time units output by kvstest
Problem: kvstest output reported time in seconds, but
the time is from monotime_since() which is in milliseconds.

Change sec to msec in the output.

@garlick garlick added the review label Dec 13, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage decreased (-0.01%) to 76.297% when pulling 285aa1d on garlick:pmi-pkg into 99a6800 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 13, 2016

Current coverage is 75.99% (diff: 100%)

Merging #921 into master will decrease coverage by 0.01%

@@             master       #921   diff @@
==========================================
  Files           149        149          
  Lines         26001      26001          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          19762      19759     -3   
- Misses         6239       6242     +3   
  Partials          0          0          

Powered by Codecov. Last update 99a6800...285aa1d

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Dec 13, 2016

Oh, nice solution here, thanks!

@grondo grondo merged commit 6ac06fa into flux-framework:master Dec 13, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 99a6800...285aa1d
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +23.99% compared to 99a6800
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 76.297%
Details

@grondo grondo removed the review label Dec 13, 2016

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.