Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #941

Merged
merged 3 commits into from Jan 6, 2017

Conversation

Projects
None yet
5 participants
@morrone
Copy link
Contributor

morrone commented Jan 6, 2017

No description provided.

morrone added some commits Dec 21, 2016

content-cache: Break up || into independent conditionals
Break up single conditional with or-statement into independent
conditionals for readability.
broker: Remove dead code
Remove dead code that was missed in an earlier code reworking.
subprocess: Fix typo
Fix minor comment typo.

@garlick garlick added the review label Jan 6, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 6, 2017

Current coverage is 76.07% (diff: 100%)

Merging #941 into master will increase coverage by <.01%

@@             master       #941   diff @@
==========================================
  Files           149        149          
  Lines         25951      25951          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          19742      19743     +1   
+ Misses         6209       6208     -1   
  Partials          0          0          
Diff Coverage File Path
•••••••••• 100% src/broker/broker.c
•••••••••• 100% src/broker/content-cache.c

Powered by Codecov. Last update 3cf4c55...8d1b322

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 6, 2017

Coverage Status

Coverage increased (+0.004%) to 76.362% when pulling 8d1b322 on morrone:minor_cleanup into 3cf4c55 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jan 6, 2017

Good, thanks! Merging.

@garlick garlick merged commit 7788f20 into flux-framework:master Jan 6, 2017

4 checks passed

codecov/patch 100% of diff hit (target 76.07%)
Details
codecov/project 76.07% (+<.01%) compared to 3cf4c55
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 76.362%
Details

@garlick garlick removed the review label Jan 6, 2017

@@ -869,8 +869,9 @@ int content_cache_set_flux (content_cache_t *cache, flux_t *h)
{
cache->h = h;

if (flux_msg_handler_addvec (h, handlers, cache) < 0
|| flux_get_rank (h, &cache->rank) < 0)
if (flux_msg_handler_addvec (h, handlers, cache) < 0)

This comment has been minimized.

@lipari

lipari Jan 6, 2017

Contributor

I'm curious. What was wrong with the old code? Readability?

This comment has been minimized.

@garlick

garlick Jan 6, 2017

Member

Lining up those error conditionals makes the flow easier to track at a glance.

@morrone morrone deleted the morrone:minor_cleanup branch Feb 25, 2017

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.