Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
wrexecd: move sending of wreck.state.complete event after job archival #955
Current coverage is 75.91% (diff: 87.50%)
@@ master #955 diff @@ ========================================== Files 153 153 Lines 26028 26030 +2 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 19760 19761 +1 - Misses 6268 6269 +1 Partials 0 0
This looks good to me, thanks!
@SteVwonder, would you be willing to flesh out the commit message a bit before we merge? E.g. shorten the title to 50 chars, then in the commit message body describe the issue and the resulting solution for posterity? Thanks.
Also I have just a couple very minor line comments I'll add presently to the commit. All very minor and not critical IMO.