Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker: Reduce use of globals #976

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
4 participants
@morrone
Copy link
Contributor

morrone commented Feb 9, 2017

First pass at reducing the use of globals and increasing encapsulation
in broker.c.

broker: Reduce use of globals
First pass at reducing the use of globals and increasing encapsulation
in broker.c.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage increased (+0.003%) to 76.186% when pulling 51a0a13 on morrone:misc_cleanup into 4270ead on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 10, 2017

This looks reasonable. Were you done or continuing on to other areas of code in this PR?

Keep in mind there's still quite a lot of work pending in the broker so don't expend too much effort rearranging things in there.

I may be offline due to weather - I have no objections to merging this as is if Chris is done and someone else wants to push the button.

@morrone

This comment has been minimized.

Copy link
Contributor Author

morrone commented Feb 10, 2017

I'm done with this one.

@grondo grondo merged commit edc914e into flux-framework:master Feb 10, 2017

4 checks passed

codecov/patch 97.5% of diff hit (target 75.91%)
Details
codecov/project 75.91% (+0%) compared to 4270ead
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 76.186%
Details

@morrone morrone deleted the morrone:misc_cleanup branch Feb 17, 2017

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.