Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libflux: flux_open() cleanup #981

Merged
merged 1 commit into from Feb 16, 2017

Conversation

Projects
None yet
4 participants
@morrone
Copy link
Contributor

morrone commented Feb 16, 2017

In flux_open(), remove a redudant if-statement and fix the function
comment to list the correct environment variable.

libflux: flux_open() cleanup
In flux_open(), remove a redudant if-statement and fix the function
comment to list the correct environment variable.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 16, 2017

Coverage Status

Coverage increased (+0.01%) to 76.219% when pulling 3be0025 on morrone:flux_open_cleanup into 0889e59 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 16, 2017

Codecov Report

Merging #981 into master will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
+ Coverage   75.93%   75.94%   +0.01%     
==========================================
  Files         152      152              
  Lines       25937    25936       -1     
==========================================
+ Hits        19694    19697       +3     
+ Misses       6243     6239       -4
Impacted Files Coverage Δ
src/common/libflux/handle.c 85.9% <71.42%> (+0.22%)
src/common/libflux/message.c 83.97% <ø> (+0.13%)
src/modules/kvs/kvs.c 80.71% <ø> (+0.24%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0889e59...3be0025. Read the comment docs.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 16, 2017

Good cleanup. Merge?

@morrone

This comment has been minimized.

Copy link
Contributor Author

morrone commented Feb 16, 2017

Yes, please. Isn't that the default assumption with pull requests that one is requesting a pull? :)

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 16, 2017

Yes though it was a bit undersized wasn't it? Thanks :-)

@garlick garlick merged commit b877c17 into flux-framework:master Feb 16, 2017

3 of 4 checks passed

codecov/patch 71.42% of diff hit (target 75.93%)
Details
codecov/project 75.94% (+0.01%) compared to 0889e59
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 76.219%
Details

@morrone morrone deleted the morrone:flux_open_cleanup branch Feb 17, 2017

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.