Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libutil/test: Update zmq test #985

Merged
merged 1 commit into from Feb 23, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Feb 22, 2017

Update zmq test to verify and document underlying behavior of using
ZMQ_FD & ZMQ_EVENT along with poll().

Fixes #524

libutil/test: Update zmq test
Update zmq test to verify and document underlying behavior of using
ZMQ_FD & ZMQ_EVENT along with poll().

Fixes #524
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage decreased (-0.02%) to 76.205% when pulling f047adf on chu11:issue524 into d42f2ca on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 23, 2017

Codecov Report

Merging #985 into master will decrease coverage by -0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   75.95%   75.93%   -0.03%     
==========================================
  Files         152      152              
  Lines       25946    25946              
==========================================
- Hits        19707    19701       -6     
- Misses       6239     6245       +6
Impacted Files Coverage Δ
src/modules/connector-local/local.c 71.8% <ø> (-1.87%)
src/modules/kvs/kvs.c 80.53% <ø> (-0.13%)
src/common/libflux/message.c 83.57% <ø> (+0.13%)
src/common/libflux/dispatch.c 82.71% <ø> (+0.28%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42f2ca...f047adf. Read the comment docs.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 23, 2017

Thanks @chu11! Perfect.

@garlick garlick merged commit 8d592e0 into flux-framework:master Feb 23, 2017

3 of 4 checks passed

codecov/project 75.93% (-0.03%) compared to d42f2ca
Details
codecov/patch Coverage not affected when comparing d42f2ca...f047adf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 76.205%
Details

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.