Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libpmi minor cleanup #986

Merged
merged 2 commits into from Feb 23, 2017

Conversation

Projects
None yet
4 participants
@morrone
Copy link
Contributor

morrone commented Feb 23, 2017

No description provided.

morrone added some commits Feb 22, 2017

libpmi: static scope "ctx" variable
Reduce namespace polution by marking the "ctx" variable static
scope.
libpmi: Change ops from pass-by-reference to pass-by-value
Change the 'ops' parameter of pmi_simple_server_create() from
pass-by-reference to pass-by-value.  Previously the function made
an internal copy of the ops structure, freeing the caller from
having to maintain the ops structure for the life of the
pmi simple server.  However, the only way to know that was to read the
code.

By changing to pass-by-value it is immediately clear to the caller,
even without a comment, that the pmi simple server code can have no
reference to the caller's struct.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage remained the same at 76.209% when pulling b7120d1 on morrone:libpmi_minor_cleanup into 8d592e0 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 23, 2017

Codecov Report

Merging #986 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   75.93%   75.93%           
=======================================
  Files         152      152           
  Lines       25946    25946           
=======================================
  Hits        19702    19702           
  Misses       6244     6244
Impacted Files Coverage Δ
src/common/libpmi/pmi2.c 0% <ø> (ø)
src/modules/wreck/wrexecd.c 75.79% <100%> (ø)
src/cmd/flux-start.c 73.46% <100%> (ø)
src/common/libpmi/simple_server.c 47.05% <100%> (ø)
src/broker/modservice.c 63.15% <ø> (-0.88%)
src/common/libflux/message.c 83.7% <ø> (ø)
src/common/libutil/veb.c 98.86% <ø> (+0.56%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d592e0...b7120d1. Read the comment docs.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 23, 2017

Works for me, thanks!

@garlick garlick merged commit e2f0823 into flux-framework:master Feb 23, 2017

4 checks passed

codecov/patch 100% of diff hit (target 75.93%)
Details
codecov/project 75.93% (+0%) compared to 8d592e0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.209%
Details

@morrone morrone deleted the morrone:libpmi_minor_cleanup branch Feb 25, 2017

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.