Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 845: Fix caliper hooks balancing & coverage in libflux/rpc #991

Merged
merged 3 commits into from Mar 8, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Feb 24, 2017

Also, add 1 cleanup patch too.

@chu11 chu11 force-pushed the chu11:issue845 branch from b6c3577 to 1fbf2e1 Feb 24, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 24, 2017

Coverage Status

Coverage decreased (-0.0002%) to 76.239% when pulling 1fbf2e1 on chu11:issue845 into 3d0fa0f on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 24, 2017

Codecov Report

Merging #991 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
+ Coverage   76.13%   76.14%   +0.01%     
==========================================
  Files         151      151              
  Lines       25989    25993       +4     
==========================================
+ Hits        19786    19793       +7     
+ Misses       6203     6200       -3
Impacted Files Coverage Δ
src/common/libflux/rpc.c 91.48% <100%> (+0.5%)
src/common/libflux/message.c 83.57% <0%> (ø)
src/modules/kvs/kvs.c 80.9% <0%> (+0.24%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2094ede...9539522. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 24, 2017

Coverage Status

Coverage decreased (-0.03%) to 76.209% when pulling 1fbf2e1 on chu11:issue845 into 3d0fa0f on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 8, 2017

I think this can go in once rebased on current master. @trws might want to have a look as time permits but I think he's away at the moment, so let's get it merged and revisit later if need be.

chu11 added some commits Feb 23, 2017

libflux/rpc: Fix imbalance of caliper hooks
Fix potential imbalance of caliper hooks due to error paths.

@chu11 chu11 force-pushed the chu11:issue845 branch from 1fbf2e1 to 9539522 Mar 8, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 8, 2017

Coverage Status

Coverage increased (+0.01%) to 76.422% when pulling 9539522 on chu11:issue845 into 2094ede on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Mar 8, 2017

rebased, seems to have passed all checks

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 8, 2017

OK thanks!

@garlick garlick merged commit adce530 into flux-framework:master Mar 8, 2017

4 checks passed

codecov/patch 100% of diff hit (target 76.13%)
Details
codecov/project 76.14% (+0.01%) compared to 2094ede
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 76.422%
Details

@grondo grondo referenced this pull request Mar 28, 2017

Closed

0.7.0 Release Notes #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.