Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in C++ configuration change to mirror flux-core #270

merged 4 commits into from Sep 27, 2017


None yet
4 participants
Copy link

commented Sep 27, 2017

This branch mirrors the changes that were made to flux-core in PR flux-framework/flux-core#1204.

morrone added some commits Sep 27, 2017

config: Convert @GCCWARN@ to $(WARNING_CFLAGS)
Change the name of GCCWARN to WARNING_CFLAGS to eliminate
the gcc-specificity from the name.  Granted it is unlikely, but
WARNING_CFLAGS might potentially have different values depending
on the detected compiler, without requiring changes to each  The name is also now in keeping with our other
*_CFLAGS named variables.

Also, we change from @GCCWARN@ to the more common variable usage

This will help a little bit with coming C++ flags.
config: Update to a newer ax_code_coverage.m4
Update ax_code_coverage.m4 to the latest from

This new version supports C++ with a CODE_COVERAGE_CXXFLAGS variable.

m4 file deprecates the former.
config: Introduce WARNING_CXXFLAGS
Introduce the WARNING_CXXFLAGS variable.
config: Require that C++ use the C++11 standard
Introduce the AX_CXX_COMPILE_STDCXX macro from

Employ the macro to set the C++ compiler to use C++11.

@morrone morrone requested a review from dongahn Sep 27, 2017


This comment has been minimized.

Copy link

commented Sep 27, 2017

Coverage Status

Coverage increased (+1.0%) to 74.67% when pulling 4c21db9 on morrone:cxx_build_changes into 15cfa5e on flux-framework:master.


This comment has been minimized.

Copy link

commented Sep 27, 2017

Codecov Report

Merging #270 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
+ Coverage   71.83%   72.17%   +0.34%     
  Files          29       29              
  Lines        5954     5862      -92     
- Hits         4277     4231      -46     
+ Misses       1677     1631      -46
Impacted Files Coverage Δ
src/common/libutil/shortjansson.h 88.33% <0%> (-0.73%) ⬇️
rdl/lua-cpuset.c 21.68% <0%> (-0.32%) ⬇️
simulator/simulator.c 83.69% <0%> (-0.28%) ⬇️
sched/flux-waitjob.c 84.82% <0%> (-0.27%) ⬇️
rdl/jansson-lua.c 82.17% <0%> (-0.18%) ⬇️
sched/sched_backfill.c 90.84% <0%> (-0.12%) ⬇️
sched/rsreader.c 96.52% <0%> (-0.08%) ⬇️
resrc/resrc_flow.c 41.19% <0%> (+0.03%) ⬆️
src/common/liblsd/list.c 34.46% <0%> (+0.13%) ⬆️
resrc/resrc.c 83.05% <0%> (+0.13%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cfa5e...4c21db9. Read the comment docs.

@@ -1,5 +1,5 @@
# ===========================================================================

This comment has been minimized.

Copy link

dongahn Sep 27, 2017


This answers my other question in your jobspec PR!


This comment has been minimized.

Copy link

commented Sep 27, 2017

Looks good to me. Merging.

@dongahn dongahn merged commit be23ee7 into flux-framework:master Sep 27, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 15cfa5e...4c21db9
codecov/project 72.17% (+0.34%) compared to 15cfa5e
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage increased (+1.0%) to 74.67%

@morrone morrone deleted the morrone:cxx_build_changes branch Nov 14, 2017

@grondo grondo referenced this pull request May 11, 2018


Need 0.5.0 Release #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.