Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: initial planner work #274

Merged
merged 3 commits into from Oct 21, 2017

Conversation

Projects
None yet
4 participants
@dongahn
Copy link
Contributor

dongahn commented Oct 20, 2017

This PR adds the initial support for planner.

Resolve Issue #267

dongahn added some commits Oct 20, 2017

planner: pull in Linux kernel's rbtree
Package this into a stand-alone library for better
separation of concerns and licensing.
planner: initial work for planner
Planner provides a simple abstraction and efficient mechanisms
to keep track of the resource states for batch-job scheduling.

resource/planner/README.md has a high-level description on
the API and its mechanisms which are based on top of
Linux OS kernel's red-black binary search tree code.

planner.h has in-lined documentation for its API.
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Oct 20, 2017

I believe I addressed all of the change requests from @morrone (posted in a closed PR #268). This should be ready to land once Travis turns green.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 20, 2017

Coverage Status

Coverage increased (+2.4%) to 77.075% when pulling 48c645e on dongahn:planner2 into a5d83bb on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 20, 2017

Codecov Report

Merging #274 into master will increase coverage by 2.63%.
The diff coverage is 85.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #274      +/-   ##
=========================================
+ Coverage   72.17%   74.8%   +2.63%     
=========================================
  Files          29      34       +5     
  Lines        5862    7332    +1470     
=========================================
+ Hits         4231    5485    +1254     
- Misses       1631    1847     +216
Impacted Files Coverage Δ
resource/planner/test/planner_test01.cpp 100% <100%> (ø)
src/common/librbtree/rbtree.h 100% <100%> (ø)
src/common/librbtree/rbtree_augmented.h 100% <100%> (ø)
src/common/librbtree/rbtree.c 74.28% <74.28%> (ø)
resource/planner/planner.c 74.62% <74.62%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d83bb...48c645e. Read the comment docs.

@morrone morrone merged commit 44c2e3e into flux-framework:master Oct 21, 2017

4 checks passed

codecov/patch 85.3% of diff hit (target 72.17%)
Details
codecov/project 74.8% (+2.63%) compared to a5d83bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.4%) to 77.075%
Details
@morrone

This comment has been minimized.

Copy link
Contributor

morrone commented Oct 21, 2017

I agree! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.