Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix mintime resource tree corruption bug #281

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
4 participants
@dongahn
Copy link
Contributor

dongahn commented Nov 19, 2017

  • Add a bug fix for a mintime resource tree corruption problem.
  • Add a test case.
  • This will be needed for upcoming resource-query test cases.

dongahn added some commits Nov 19, 2017

planner: fix mintime resource tree corruption bug
Fix a bug where the ending scheduled point of a span is
not removed from the mintime resource search tree.
W/ enough add, remove and add operation, this leads to SEGV.

Clean up the scheduled point reference-count code.
planner: Add a test for add followed by remove and add
This is good enough to cause the prevision version to SEGV.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 19, 2017

Coverage Status

Coverage increased (+0.6%) to 77.788% when pulling 5dbde50 on dongahn:planner_bug_fix into e068c92 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 19, 2017

Codecov Report

Merging #281 into master will increase coverage by 0.53%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   74.92%   75.46%   +0.53%     
==========================================
  Files          34       34              
  Lines        7359     7419      +60     
==========================================
+ Hits         5514     5599      +85     
+ Misses       1845     1820      -25
Impacted Files Coverage Δ
resource/planner/test/planner_test01.cpp 100% <100%> (ø) ⬆️
resource/planner/planner.c 76.51% <90.9%> (+1.88%) ⬆️
src/common/librbtree/rbtree.c 81.71% <0%> (+7.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e068c92...5dbde50. Read the comment docs.

@morrone morrone merged commit 9adf92e into flux-framework:master Nov 22, 2017

4 checks passed

codecov/patch 98.55% of diff hit (target 74.92%)
Details
codecov/project 75.46% (+0.53%) compared to e068c92
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 77.788%
Details
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Nov 22, 2017

Thanks!

@grondo grondo referenced this pull request May 11, 2018

Closed

Need 0.5.0 Release #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.