Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve portability issues for Ubuntu 17.10 #301

Merged
merged 4 commits into from Mar 31, 2018

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Mar 31, 2018

Here are a few minor fixes for issues that came up building sched on my i386 Ubuntu 17.10 test VM, which has gcc-7.2.0.

No issues with the native boost 1.62 on this system.

garlick added some commits Mar 31, 2018

build/liblsd: add -Wno-parentheses for gcc7
Problem:  liblsd/list.c fails to compile due to a new
gcc7 "no-parentheses" warning.

Add -Wno-parentheses to ignore this warning since liblsd
was imported from another source.
rdl: [cleanup] expand tabs in lua-cpuset.c
Problem: rdl/lua-cpuset.c fails to compile due to a new
gcc7 misleading-indentation error.

The "problem" seems to come simply from inconsistent
use of tabs vs spaces for indentation.  Since expandtab
is set in the modeline, just convert all tabs to spaces
in that file.
resrc: fix format errors
Problem: gcc7 (i386) reports a mismatch between size_t
values and PRIu64 printf format strings.

Use %zd format for size_t.
simulator: fix format error
Problem: 64-bit integer id is printed with %lu, causing
gcc7 format error.

Use PRId64 instead.
@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Mar 31, 2018

Nice cleanup @garlick! I will merge it once Travis turns green.

BTW, this reminds me, at some point, I need to change the size_t used for real physical quantities in resrc either uint64_t or unsigned int since size_t shouldn't be used for this kind.

@garlick garlick force-pushed the garlick:gcc7 branch from 731be95 to e8d1e5b Mar 31, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 31, 2018

Codecov Report

Merging #301 into master will not change coverage.
The diff coverage is 20%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   67.74%   67.74%           
=======================================
  Files          46       46           
  Lines        8692     8692           
=======================================
  Hits         5888     5888           
  Misses       2804     2804
Impacted Files Coverage Δ
resrc/resrc.c 81.77% <0%> (ø) ⬆️
resrc/resrc_reqst.c 90.9% <0%> (ø) ⬆️
rdl/lua-cpuset.c 21.68% <23.52%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027a522...e8d1e5b. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 31, 2018

Coverage Status

Coverage remained the same at 68.968% when pulling e8d1e5b on garlick:gcc7 into 027a522 on flux-framework:master.

@dongahn dongahn merged commit 02b17e9 into flux-framework:master Mar 31, 2018

3 of 4 checks passed

codecov/patch 20% of diff hit (target 67.74%)
Details
codecov/project 67.74% remains the same compared to 027a522
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 68.968%
Details

@grondo grondo referenced this pull request May 11, 2018

Closed

Need 0.5.0 Release #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.