Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for reading hwloc xml files generated from Sierra compute nodes #310

Merged
merged 2 commits into from Apr 10, 2018

Conversation

Projects
None yet
4 participants
@dongahn
Copy link
Contributor

dongahn commented Apr 10, 2018

Per discussion at #308:

Incorporate @trws' patch to handle group type.

Add a test case using hwloc xml files collected from Sierra nodes.

dongahn added some commits Apr 10, 2018

resrc: Add support for HWLOC group type
Add @twrs' patch.

Need this on the hwloc generated from LLNL's Sierra machine.

hwloc-ls --version reports 1.11.2
test: Add hwloc tests using Sierra P9/Volta nodes
Generate and add xml files using lstopo on 4 Sierra compute nodes.

Run a smoke test to validate that `resrc` likes the format.

@dongahn dongahn requested review from trws and SteVwonder Apr 10, 2018

@SteVwonder
Copy link
Member

SteVwonder left a comment

LGTM. Thanks @dongahn!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2018

Codecov Report

Merging #310 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   74.11%   74.12%   +<.01%     
==========================================
  Files          49       49              
  Lines        9287     9290       +3     
==========================================
+ Hits         6883     6886       +3     
  Misses       2404     2404
Impacted Files Coverage Δ
resrc/resrc.c 83.12% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc03941...055bb80. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 10, 2018

Coverage Status

Coverage increased (+0.008%) to 75.859% when pulling 055bb80 on dongahn:sierra-hwloc into cc03941 on flux-framework:master.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Apr 10, 2018

@dongahn, do you have a preference for what gets merged first, between this PR and #305?

@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Apr 10, 2018

No I don't. But I think this can go in first now that it looks like i will have to fix a CI failure on the other PR...

@SteVwonder SteVwonder merged commit 722e241 into flux-framework:master Apr 10, 2018

4 checks passed

codecov/patch 100% of diff hit (target 74.11%)
Details
codecov/project 74.12% (+<.01%) compared to cc03941
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.008%) to 75.859%
Details

@grondo grondo referenced this pull request May 11, 2018

Closed

Need 0.5.0 Release #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.