Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R_lite: Add the node key to support hostlist #324

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
5 participants
@dongahn
Copy link
Contributor

dongahn commented Apr 27, 2018

This PR addresses a part of the hostlist support as discussed in flux-framework/flux-core#1489

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 27, 2018

Coverage Status

Coverage decreased (-0.003%) to 75.207% when pulling f753733 on dongahn:R_lite-hostname into aa24fdf on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #324 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   73.65%   73.65%   -0.01%     
==========================================
  Files          56       56              
  Lines        9786     9785       -1     
==========================================
- Hits         7208     7207       -1     
  Misses       2578     2578
Impacted Files Coverage Δ
sched/sched.c 73.96% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa24fdf...f753733. Read the comment docs.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Apr 27, 2018

Nice! Thanks! Let me give it a spin after lunch, but LGTM.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Apr 27, 2018

LGTM too. Thanks @dongahn.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Apr 27, 2018

Ok, tried this out on a system and seems to work as designed thanks!

$ flux kvs get lwj.0.0.2.R_lite
[ { "node": "ipa1", "children": { "core": "0,1,2,3,4,5,6,7" }, "rank": 0 }, { "node": "ipa7", "children": { "core": "0,1,2,3,4,5,6,7" }, "rank": 1 } ]
t$ ./hostlist.lua 2
ipa1
ipa7

One thing to note unrelated to this PR is that the "core" list in R_lite is read as cpu_set_t, so the above could be written as { "core": "0-7" } for brevity, however this isn't critical at all.

I'll go ahead and merge this PR.

@grondo grondo merged commit cb78d4a into flux-framework:master Apr 27, 2018

3 of 4 checks passed

codecov/project 73.65% (-0.01%) compared to aa24fdf
Details
codecov/patch Coverage not affected when comparing aa24fdf...f753733
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 75.207%
Details
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Apr 27, 2018

Thanks. And yes condensing the core list can be easily done using @garlick's APi ( i forgot the name). I was planning to do that when I get to this next time. Will create a ticket to track it.

@grondo grondo referenced this pull request May 11, 2018

Closed

Need 0.5.0 Release #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.