Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
experimental: add valgrind test to flux-sched, fix some leaks #328
This somewhat experimental PR adds the
The leaks fixed here were all fairly obvious given valgrind output in #327 . One thing that happened was when shortjson.h was switched to shortjansson.h, the fact that
This isn't ready for merge yet. I may need to iterate on the valgrind test implementation.
@@ Coverage Diff @@ ## master #328 +/- ## ========================================== + Coverage 73.65% 73.68% +0.02% ========================================== Files 56 56 Lines 9785 9811 +26 ========================================== + Hits 7207 7229 +22 - Misses 2578 2582 +4
@dongahn: There's one last minor flux-sched leak detected by valgrind for which I think I'll need your help:
Otherwise, once a couple libjsc leak fixes are landed in flux-core, this valgrind test at least will run clean for flux-sched.
Thanks @dongahn, your fix appeared to work, and along with jsc fixes in core, the valgrind test runs clean:
I'll update this PR with your fix, plus I will remove the
Apr 30, 2018
Sorry running the tests in