Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched: remove trailing whitespaces #376

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
5 participants
@dongahn
Copy link
Contributor

dongahn commented Aug 8, 2018

Just noticed trailing whitespaces that were introduced from the latest changes.

If vim is used, adding the following to ~/.vimrc should highlight the trailing whitespaces for C code, which can help one not introduce them:

let c_space_errors = 1
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   75.88%   75.88%           
=======================================
  Files          59       59           
  Lines        9829     9829           
=======================================
  Hits         7459     7459           
  Misses       2370     2370
Impacted Files Coverage Δ
sched/sched.c 73.49% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85cd12...9cb5375. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 8, 2018

Coverage Status

Coverage remained the same at 77.545% when pulling 9cb5375 on dongahn:matching-service into d85cd12 on flux-framework:master.

@dongahn dongahn requested a review from tpatki Aug 9, 2018

@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Aug 9, 2018

I think the codecov check is bogus as this PR only contains trailing whitespace removal.

@tpatki

tpatki approved these changes Aug 9, 2018

Copy link
Contributor

tpatki left a comment

Looks good, and yes, noted the vimrc point. Merging.

@tpatki tpatki merged commit 3f36f33 into flux-framework:master Aug 9, 2018

3 of 4 checks passed

codecov/patch 75% of diff hit (target 75.88%)
Details
codecov/project 75.88% remains the same compared to d85cd12
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 77.545%
Details
@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Aug 10, 2018

👍 We should add style checking for stuff like this as part of make check and the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.