Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource: wire in --prune-filters option for resource-query and matching module #401

Merged
merged 8 commits into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@dongahn
Copy link
Contributor

dongahn commented Nov 2, 2018

This PR resolves Issue #399.

  • Clean up how to specify pruning filters through either a command line argument or load option
  • Add methods to parse a spec and populate filter maps within matcher_util_api_t
  • Use these methods within the traverser to implant filters selectively
  • Wire in this option within both resource-query and resource matching module
  • Default set to ALL:core for both CLI and module for now.

Due to time constraints, I plan to address #400 in a separate PR.

@dongahn dongahn requested a review from SteVwonder Nov 2, 2018

@dongahn dongahn force-pushed the dongahn:prune-filter branch from e15a268 to 34d1264 Nov 2, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 2, 2018

Codecov Report

Merging #401 into master will decrease coverage by 0.01%.
The diff coverage is 71.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage    75.7%   75.68%   -0.02%     
==========================================
  Files          67       67              
  Lines       10768    10817      +49     
==========================================
+ Hits         8152     8187      +35     
- Misses       2616     2630      +14
Impacted Files Coverage Δ
resource/policies/base/matcher.hpp 100% <ø> (ø) ⬆️
resource/utilities/command.hpp 100% <ø> (ø) ⬆️
resource/traversers/dfu_impl.hpp 100% <ø> (ø) ⬆️
resource/traversers/dfu.cpp 73.68% <100%> (ø) ⬆️
resource/traversers/dfu_impl.cpp 82.63% <100%> (+0.06%) ⬆️
resource/utilities/resource-query.cpp 35.74% <40%> (-0.7%) ⬇️
resource/modules/resource_match.cpp 71.66% <50%> (-0.33%) ⬇️
resource/policies/base/matcher.cpp 73.21% <68.75%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2580f41...34d1264. Read the comment docs.

@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Nov 2, 2018

Coverage slightly decreased. When I can get to #400 and #388, I plan add more tests to coverage more code.

@SteVwonder
Copy link
Member

SteVwonder left a comment

Looking good to me. Ready for this to be merged?

@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Nov 2, 2018

Yes. Thanks.

@SteVwonder SteVwonder merged commit da6fad6 into flux-framework:master Nov 2, 2018

1 of 3 checks passed

codecov/patch 71.01% of diff hit (target 75.7%)
Details
codecov/project 75.68% (-0.02%) compared to 2580f41
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.