Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add libtoolize into autogen.sh #406

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@dongahn
Copy link
Contributor

dongahn commented Nov 8, 2018

This PR uses libtoolize to resolve Issue #402. It also pulls in some of the options that flux-core is using for consistency.

The autoreconf verbose option catches autoreconf: configure.ac: not using Gettext. But I don't think we are ready to add Gettext support so I will leave it this way.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #406 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #406   +/-   ##
=======================================
  Coverage   75.68%   75.68%           
=======================================
  Files          67       67           
  Lines       10817    10817           
=======================================
  Hits         8187     8187           
  Misses       2630     2630

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef33aa...e2a53e5. Read the comment docs.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Nov 8, 2018

Thanks @dongahn!

@SteVwonder SteVwonder merged commit 6f42674 into flux-framework:master Nov 8, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 6ef33aa...e2a53e5
Details
codecov/project 75.68% remains the same compared to 6ef33aa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.