Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched/plugin: track flux-core module API changes #414

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Nov 29, 2018

Problem: flux-core dropped the RFC 5 payload encode/decode
helper functions, and changed the prototype of the
flux_modname() and flux_modfind() functions.

Update sched/plugin to conform to these API changes.

This should go in after flux-framework/flux-core#1856

sched/plugin: track flux-core module API changes
Problem: flux-core dropped the RFC 5 payload encode/decode
helper functions, and changed the prototype of the
flux_modname() and flux_modfind() functions.

Update sched/plugin to conform to these API changes.

@garlick garlick force-pushed the garlick:modapi_update branch from 1b9029d to 526c16d Nov 29, 2018

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Nov 30, 2018

Restarted Travis since flux-framework/flux-core#1856 was merged to flux-core/master

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #414 into master will decrease coverage by 0.15%.
The diff coverage is 57.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   75.68%   75.53%   -0.16%     
==========================================
  Files          67       67              
  Lines       10817    10831      +14     
==========================================
- Hits         8187     8181       -6     
- Misses       2630     2650      +20
Impacted Files Coverage Δ
sched/plugin.c 51.92% <57.81%> (-5.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f42674...526c16d. Read the comment docs.

@SteVwonder
Copy link
Member

SteVwonder left a comment

Code changes LGTM! Gave it a test run and everything seems to work as intended.

Took a peek at the code coverage results, and it appears that the low coverage is mainly error paths. Additionally, I noticed that the priority plugin code is not covered because we don't have any priority plugins to test against 😱. I'll open a ticket for that now.

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Dec 3, 2018

Thanks for that @SteVwonder !

Note that travis will be failing on other PR's until this goes in, since flux-framework/flux-core#1856 was merged.

@SteVwonder SteVwonder merged commit aef18a9 into flux-framework:master Dec 3, 2018

1 of 3 checks passed

codecov/patch 57.81% of diff hit (target 75.68%)
Details
codecov/project 75.53% (-0.16%) compared to 6f42674
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.