Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource: Add run-level support for resource matching module #418

Merged
merged 3 commits into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@dongahn
Copy link
Contributor

dongahn commented Dec 14, 2018

  • Change the default argument of the prune-filters load option to ALL:pu
  • Adjust test cases
  • Add rc1 and rc3 script for resource
  • Update make rules

Resolve Issue #389.

dongahn added some commits Dec 14, 2018

resource: Change default prune-filters to ALL:pu
Set prune-filters=ALL:pu as the default in preparation
for adding the rc1 and rc2 support for the resource
matching service module (hwloc reader mode being default).

The old default of prune-filters=ALL:core has issues
with hwloc reader mode. So at first glance, we can
avoid this issue by setting prune-filters=ALL:pu
at the rc1 level.

But as the rc1 script will also need to support
the FLUX_RESOURCE_OPTIONS environment variable,
through which users can change resource
load options including prune-filter,
trying to solving it at the rc1 level
can have a side effect.

Adjust resource matching service test cases accordingly.

@dongahn dongahn requested a review from SteVwonder Dec 14, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #418 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files          67       67           
  Lines       10992    10992           
=======================================
  Hits         8313     8313           
  Misses       2679     2679
Impacted Files Coverage Δ
resource/modules/resource_match.cpp 71.63% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781b95e...909b461. Read the comment docs.

@SteVwonder
Copy link
Member

SteVwonder left a comment

LGTM! Gave it a test on ~60 nodes and the module loaded instantly.

I'll merge later today if no one else chimes in.

@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Dec 17, 2018

Great. Thanks!

@SteVwonder SteVwonder merged commit a89b170 into flux-framework:master Dec 18, 2018

3 checks passed

codecov/patch 100% of diff hit (target 75.62%)
Details
codecov/project 75.62% (+0%) compared to 781b95e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Dec 18, 2018

Thanks @SteVwonder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.