Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure scheduling correctness with different prune filter configurations #419
This PR add various fixes to ensure correctness around the use of pruning filters.
@@ Coverage Diff @@ ## master #419 +/- ## ========================================== + Coverage 75.62% 75.67% +0.04% ========================================== Files 67 67 Lines 10992 11026 +34 ========================================== + Hits 8313 8344 +31 - Misses 2679 2682 +3
referenced this pull request
Jan 10, 2019
SteVwonder left a comment •
Thanks @dongahn for this fix (and giving me the high-level overview on the whiteboard). Generally, looks good to me!
Left a few comments that could be optimizations or could be misunderstandings of the logic on my end.
Related: in #385, I change the default prune filter for
@SteVwonder: Thank you for thorough review!
This is actually intended. We use
Also intended. Wanted to make sure specifying the same filter type as the default leads to correct scheduling behavior.
@SteVwonder: The last three commits should address your comments. I decide to change the
Rebased to the current master. Let me know if I miss something from your reviews.