Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: fix docker and github release deployment #424

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@grondo
Copy link
Contributor

grondo commented Jan 9, 2019

This addresses missing Docker image deploy as noted by @SteVwonder in #423 (sorry about that!), and also moves the Github release deploy test to look for an explicit environment variable (GITHUB_RELEASES_DEPLOY) instead of triggering off TRAVIS_BUILD_NUMBER == 1. (Though there was nothing to fix here, keeping in sync with flux-core seemed wise)

To generate the DOCKER_PASSWORD environment variable, I ran travis encrypt within the flux-sched repo, and pasted in the current password for the travisflux user on DockerHub:

$ travis encrypt
Reading from stdin, press Ctrl+D when done
blah blah blah blah
<C-d>
Please add the following to your .travis.yml file:

  secure: "sqG5Gimp...="

Pro Tip: You can add it automatically by running with --add.

Then pasted the secure: key into place.

grondo added some commits Jan 9, 2019

travis-ci: add missing docker deploy
Add missing stanza in after_success to deploy new docker tags up
to Docker Hub, and add the password for the travisflux user as
a secure environment variable DOCKER_PASSWORD.

Fixes #423
travis-ci: fixup github release deployment check
Instead of triggering GitHub Release deployment arbitrarily off
the build with TRAVIS_BUILD_NUMBER = 1, set an explicit environment
variable GITHUB_RELEASES_DEPLOY and trigger deploy off that.

This is the same thing done in flux-core.
@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Jan 9, 2019

LGTM! Thanks @grondo for putting this together.

Is this good to merge now, or do you want to wait to test on your fork?

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jan 9, 2019

It is a bit challenging to test in my own repo, so let's merge this one. If it still fails to deploy then I'll go through the work of setting up a test environment to figure out what went wrong.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Jan 10, 2019

Sounds good. Merging now. Thanks @grondo!

@SteVwonder SteVwonder merged commit 1ed7a4c into flux-framework:master Jan 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jan 10, 2019

Thanks! Let's hope that works...

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jan 10, 2019

Thanks! Let's hope that works...

Uh, nope. There is no repo for flux-sched yet at Docker Hub.
Also got

Error: Cannot perform an interactive login from a non TTY device

Hopefully that error will go away after I create a fluxrm/flux-sched repo...

@grondo grondo deleted the grondo:travis-deploy-fixups branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.