Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: update repo tag names, ensure flux-sched installed with prefix=/usr #427

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Jan 10, 2019

Ok, a couple more cleanups of the Docker build/deploy here:

  • Update Dockerfiles to pull from fluxrm/flux-core:bionic or :centos7 tags
  • Pass --prefix=/usr to docker-deploy builds so that flux-sched is installed to the same prefix as flux-core.

grondo added some commits Jan 10, 2019

docker: drop -base-latest suffix from source images
flux-core docker images are now pushed to Docker Hub without the
-base-latest suffix, i.e. the latest Ubuntu image is available at

 fluxrm/flux-core:bionic

and the latest CentOS7 image is at

 fluxrm/flux-core:centos7

Ensure flux-sched docker builds are pulling from these tags, and
follow the same practice for the tags pushed to Docker Hub for
flux-sched master and tagged builds.
travis-ci: pass --prefix=/usr to docker-deploy builds
Problem: flux-sched was installed to prefix=/usr/local in its
Docker images, while flux-core is installed under /usr.

Pass --prefix=/usr to docker-deploy builds so flux-sched and
flux-core are installed to the same prefix.
@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jan 10, 2019

No need for this to go in before #419, but it should be merged before the next tag.

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Jan 10, 2019

I think it would be better for this to go in first as the last set of commits were also docker related. I can rebase PR #419 after that.

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jan 10, 2019

Ok, I just didn't want you to have to unnecessarily rebase. Thanks!

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Jan 10, 2019

LGTM from my perspective. But it would be good if @SteVwonder can take a brief look at it since he knows more about this than me.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files          67       67           
  Lines       10992    10992           
=======================================
  Hits         8313     8313           
  Misses       2679     2679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3b36e...328a079. Read the comment docs.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Jan 10, 2019

LGTM! Merging!

@SteVwonder SteVwonder merged commit 8541aba into flux-framework:master Jan 10, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 2d3b36e...328a079
Details
codecov/project 75.62% remains the same compared to 2d3b36e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jan 10, 2019

Thanks and sorry for all the noise!

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Jan 11, 2019

@grondo, thanks for taking care of all of this! Looks like it worked.

CC @koning: you should be able to pull fluxrm/flux-sched:latest off docker hub now.

@grondo grondo deleted the grondo:docker-name-change branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.