Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add yaml-cpp dependency #428

Merged
merged 3 commits into from Jan 15, 2019

Conversation

Projects
None yet
3 participants
@garlick
Copy link
Member

garlick commented Jan 15, 2019

In flux-framework/flux-core#1922, we are dropping yaml-cpp as a dependency, hence dropping it from the flux-core Dockerfiles.

This PR adds it to the sched Dockerfiles.

@@ -11,7 +11,8 @@ RUN sudo apt-get -qq install -y --no-install-recommends \
libboost-filesystem-dev \
libboost-regex-dev \
libxml2-dev \
python-yaml
python-yaml \

This comment has been minimized.

@dongahn

dongahn Jan 15, 2019

Contributor

Looks good to me.

Using my web browser, I see an extra leading whitespace for the line before this (libxml2-dev). While you are on it, can we get rid of it.

Also, I just noticed our main README.md fails to list python-yaml and libyaml-cpp-dev as our dependencies. Do you think it makes sense to update that REAME.md as part of this PR as well?

This comment has been minimized.

@garlick

garlick Jan 15, 2019

Author Member

Will address both - thanks!

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Jan 15, 2019

@garlick: LGTM. Will merge once Travis turns green. Thanks.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files          67       67           
  Lines       10992    10992           
=======================================
  Hits         8313     8313           
  Misses       2679     2679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8541aba...270c160. Read the comment docs.

@dongahn dongahn merged commit cf92d6d into flux-framework:master Jan 15, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 8541aba...270c160
Details
codecov/project 75.62% remains the same compared to 8541aba
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.