Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues for priority_mod_fair_tree.so #434

Merged
merged 2 commits into from Jan 31, 2019

Conversation

@grondo
Copy link
Contributor

grondo commented Jan 31, 2019

As discussed in #433, this PR fixes a couple build issues for the modified fair tree plugin.

grondo added 2 commits Jan 30, 2019
Problem: the plugin priority_mod_fair_tree.so does not export the
`mod_name` symbol as required for Flux Extension Modules as specified
in RFC 5. This causes an error whenever the flux-module utility
dlopen()'s this module to look for its name.

Add the `mod_name` symbol via the MOD_NAME() macro as required by
the spec, and ensure the symbol is exported in the DSO by adding
it to the -export-symbol-regex linker flag.

Fixes #433
Problem: the sched priority_mod_fair_tree.so plugin is installed into
$libdir directly instead of under $libdir/flux/sched as required to be
found by the flux-module frontend command.

The build system already exports $schedplugindir, so move the
priority_mod_fair_tree.so from lib_LTLIBRARIES to schedplugin_LTLIBRARIES.

Fixes #344
@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jan 31, 2019

restarted a hung builder.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files          67       67           
  Lines       11026    11026           
=======================================
  Hits         8344     8344           
  Misses       2682     2682

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c019e2f...7574f0c. Read the comment docs.

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Jan 31, 2019

LGTM, @grondo. Thanks!

@dongahn dongahn merged commit 7e50a80 into flux-framework:master Jan 31, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing c019e2f...7574f0c
Details
codecov/project 75.67% remains the same compared to c019e2f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.