Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/sched/simulator: Update KVS API usage #435

Merged
merged 1 commit into from Feb 3, 2019

Conversation

@chu11
Copy link
Contributor

chu11 commented Feb 1, 2019

Update usage of flux_kvs_lookup(), flux_kvs_watch_once(), and
flux_kvs_commit() given changes in flux-core flux-framework/flux-core#1977

Update usage of flux_kvs_lookup(), flux_kvs_watch_once(), and
flux_kvs_commit() given changes in flux-core PR #1977.
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 2, 2019

with flux core #1977 merged, this should be ok to merge now, hit restart on travis

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #435 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   75.67%   75.68%   +<.01%     
==========================================
  Files          67       67              
  Lines       11026    11028       +2     
==========================================
+ Hits         8344     8346       +2     
  Misses       2682     2682
Impacted Files Coverage Δ
simulator/simulator.c 90.23% <100%> (+0.07%) ⬆️
resource/modules/resource_match.cpp 75.28% <100%> (ø) ⬆️
sched/sched.c 73.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e50a80...ba520c3. Read the comment docs.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Feb 3, 2019

Thanks @chu11! LGTM! Merging.

@SteVwonder SteVwonder merged commit 458c345 into flux-framework:master Feb 3, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 75.67%)
Details
codecov/project 75.68% (+<.01%) compared to 7e50a80
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.