Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource: Update for kvs watch API removal #442

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@chu11
Copy link
Contributor

chu11 commented Feb 13, 2019

Replace call to flux_kvs_watch_once() with flux_kvs_lookup().

Should be merged after flux-framework/flux-core#2011 is accepted.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #442 into master will decrease coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   75.08%   75.05%   -0.04%     
==========================================
  Files          43       43              
  Lines        4988     4990       +2     
==========================================
  Hits         3745     3745              
- Misses       1243     1245       +2
Impacted Files Coverage Δ
resource/modules/resource_match.cpp 74.85% <57.14%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999858c...ea98261. Read the comment docs.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Feb 13, 2019

Should be merged after flux-framework/flux-core#2011 is accepted.

isn't this a change that can be merged in to flux-sched now (moving from deprecated to non-deprecated interface)?

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 13, 2019

isn't this a change that can be merged in to flux-sched now (moving from deprecated to non-deprecated interface)?

Oh yeah, you're correct! It doesn't require that the old watch API is removed :-)

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Feb 14, 2019

Thanks @chu11! Sorry that I propagated the use of a deprecated function.

Replace call to flux_kvs_watch_once() with flux_kvs_lookup().
@chu11 chu11 force-pushed the chu11:watchapiremovalupdate branch from 5f3e0e7 to ea98261 Feb 14, 2019
Copy link
Member

SteVwonder left a comment

LGTM! Thanks @chu11!

@SteVwonder SteVwonder merged commit ef830cc into flux-framework:master Feb 15, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 57.14% of diff hit (target 75.08%)
Details
codecov/project 75.05% (-0.04%) compared to 999858c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.