Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: remove the use of deprecated Python API #450

merged 1 commit into from Mar 12, 2019


Copy link

dongahn commented Mar 11, 2019

This PR resolves Issue #449.

Replace rpc_send () to rpc ().get () within flux-resource testing front end to track the recent Python API change.

Replace rpc_send to rpc ().get () to track the recent
Python API change.

This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #450 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #450   +/-   ##
  Coverage   75.05%   75.05%           
  Files          43       43           
  Lines        4990     4990           
  Hits         3745     3745           
  Misses       1245     1245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef830cc...10ac494. Read the comment docs.

@dongahn dongahn requested a review from SteVwonder Mar 11, 2019

This comment has been minimized.

Copy link

SteVwonder commented Mar 12, 2019

Thanks @dongahn! LGTM!

(My apologies for making the breaking changes in flux-core and not following up with a check of flux-sched).

@SteVwonder SteVwonder merged commit a8209cc into flux-framework:master Mar 12, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing ef830cc...10ac494
codecov/project 75.05% remains the same compared to ef830cc
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Mar 12, 2019

Not a problem. Thanks @SteVwonder for reviewing and merging it.

@dongahn dongahn deleted the dongahn:python-rpc branch Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.