Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_match: update to flux_respond_error() #457

Merged
merged 1 commit into from Apr 18, 2019

Conversation

@grondo
Copy link
Contributor

grondo commented Apr 18, 2019

Basically just substitute flux_respond_error (h, msg, errno, NULL) with flux_respond_error().

Also added "flux_respond_error" to the error log for these functions, for ease of debugging if something goes wrong.

Track changes to flux_respond() and flux_respond_error() in flux-core.

Update error response calls from

 flux_respond (h, msg, errno, NULL);

to

 flux_respond_error (h, msg, errno, NULL)

Fixes #456
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #457 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   75.05%   75.05%           
=======================================
  Files          43       43           
  Lines        4990     4990           
=======================================
  Hits         3745     3745           
  Misses       1245     1245
Impacted Files Coverage Δ
resource/modules/resource_match.cpp 74.85% <25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8209cc...9aa63da. Read the comment docs.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Apr 18, 2019

LGTM! Thanks @grondo!

@SteVwonder SteVwonder merged commit 0aa79e1 into flux-framework:master Apr 18, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 25% of diff hit (target 75.05%)
Details
codecov/project 75.05% remains the same compared to a8209cc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo grondo deleted the grondo:issue#456 branch Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.