Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases to support systems with disaggregated resources #460

Merged
merged 3 commits into from Jun 5, 2019

Conversation

@dongahn
Copy link
Contributor

dongahn commented Apr 28, 2019

  • Add a very large "theoretical" system built with the concept of disaggregated resources
  • Add a few jobspecs that can match with these disaggregated resources
  • Extend advanced test cases to make use of them (guard them with LONGTEST since the system configuration is as large as today's pre-exascale system like Sierra.)

Resolve Issue #459.

This should be merged after PR #455 is merged first.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 28, 2019

Codecov Report

Merging #460 into master will not change coverage.
The diff coverage is 70.51%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files          45       45           
  Lines        5477     5477           
=======================================
  Hits         4173     4173           
  Misses       1304     1304
Impacted Files Coverage Δ
resource/writers/match_writers.hpp 100% <ø> (ø) ⬆️
resource/utilities/command.hpp 100% <ø> (ø) ⬆️
resource/traversers/dfu_impl.hpp 100% <ø> (ø) ⬆️
resource/planner/planner_multi.c 62.75% <100%> (ø) ⬆️
resource/policies/base/matcher.cpp 66.91% <100%> (ø) ⬆️
resource/generators/gen.cpp 87.08% <100%> (ø) ⬆️
resource/writers/match_writers.cpp 92.98% <100%> (ø) ⬆️
resource/modules/resource_match.cpp 71.46% <45.16%> (ø) ⬆️
resource/schema/resource_data.cpp 52.63% <50%> (ø) ⬆️
resource/traversers/dfu_impl.cpp 82.72% <80%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3dcb3d...8ed2d83. Read the comment docs.

Copy link
Member

SteVwonder left a comment

LGTM! I'll take another quick look once #455 is merged and this is rebased, but the last three commits on this PR look good (I believe all of the other commits are from #455).

#
# Selection Policy -- High ID first (-P high)
# The resource vertex with higher ID is preferred among its kind
# (e.g., node0 is preferred over node1 if available)

This comment has been minimized.

Copy link
@SteVwonder

SteVwonder May 31, 2019

Member
Suggested change
# (e.g., node0 is preferred over node1 if available)
# (e.g., node1 is preferred over node0 if available)

This comment has been minimized.

Copy link
@dongahn

dongahn May 31, 2019

Author Contributor

Good catch! Thanks.

This comment has been minimized.

Copy link
@dongahn

dongahn May 31, 2019

Author Contributor

Ok. I made this change and squash it w/ the last commit. After PR #455 is merged, I will rebase this to upstream/master and force a push.

t/t3006-resource-advanced.t Show resolved Hide resolved
@dongahn dongahn force-pushed the dongahn:test-disaggr branch from 0503174 to 8ed2d83 Jun 3, 2019
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Jun 3, 2019

@SteVwonder: Ok. I rebased this to the upstream master and forced a push. I believe this is ready to be merged once Travis turns green. Thanks!

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Jun 5, 2019

Thanks @dongahn. LGTM! This is a really cool demonstration of the flexibility and power of the scheduler.

Merging.

@SteVwonder SteVwonder merged commit 0904670 into flux-framework:master Jun 5, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing a3dcb3d...8ed2d83
Details
codecov/project 76.19% remains the same compared to a3dcb3d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Jun 5, 2019

Thanks @SteVwonder! Yeah exciting time.

@dongahn dongahn deleted the dongahn:test-disaggr branch Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.