Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: update flux-sharness.sh to version from flux-core #523

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@grondo
Copy link
Contributor

grondo commented Oct 1, 2019

The flux-broker no longer supports FLUX_RC1_PATH and FLUX_RC3_PATH.
Update to flux-sharness.sh from flux-core so that test_under_flux
no longer uses these variables.

When testing this update I was getting some hangs, though I'm not sure how it is related to this PR. I'll keep poking at it, but wanted to propose this update sooner than later.

The flux-broker no longer supports FLUX_RC1_PATH and FLUX_RC3_PATH.
Update to flux-sharness.sh from flux-core so that test_under_flux
no longer uses these variables.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   76.55%   76.55%           
=======================================
  Files          58       58           
  Lines        6291     6291           
=======================================
  Hits         4816     4816           
  Misses       1475     1475

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d7438...619209c. Read the comment docs.

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Oct 1, 2019

@grondo: This looks good to me. Is there a flux-core issue ticket or PR to which we can refer this? I wasn't aware of this change and I would be good to leave a trail in this PR.

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Oct 1, 2019

Good point. Referencing PR flux-framework/flux-core#2431 and issue flux-framework/flux-core#2304

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Oct 1, 2019

Since the validator module issue I was hitting is only on fluke without .notce, this PR is probably ok to go in.

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Oct 1, 2019

Yap. Sounds good to me.

@dongahn dongahn merged commit 4d5ad4b into flux-framework:master Oct 1, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 77d7438...619209c
Details
codecov/project 76.55% remains the same compared to 77d7438
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.