Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc3: Fix a bug in RC3 dir definition within configure.ac #525

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@dongahn
Copy link
Contributor

dongahn commented Oct 1, 2019

Fix a copy-and-paste error in the rc3 directory definition for qmanager. Without a proper rc3, qmanager wasn't cleanly exited when the Flux instance is torn down:

module 'qmanager' was not cleanly shutdown

Resolve #524.

Fix a copy-and-paste error in the rc3 directory definition
for qmanager. Without a proper rc3, qmanager wasn't cleanly
exited when the Flux instance is torn down:

"module 'qmanager' was not cleanly shutdown"
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 1, 2019

I restarted a builder that had a very strange error in the hwloc tests. (Couldn't even tell what went wrong, suddenly the broker was gone)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #525 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #525   +/-   ##
=======================================
  Coverage   76.55%   76.55%           
=======================================
  Files          58       58           
  Lines        6291     6291           
=======================================
  Hits         4816     4816           
  Misses       1475     1475

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5ad4b...300982a. Read the comment docs.

@grondo
grondo approved these changes Oct 1, 2019
Copy link
Contributor

grondo left a comment

LGTM! Tested after make install. We still have the error

 broker.err[0]: rc3: flux-module: cmb.rmmod[0] sched-simple: No such file or directory

But it would be kind of silly for flux-sched's rc3 script to reload sched-simple in order to work around this error. We need to give better tools in flux-core for this kind of thing.

I think it is ok to just let this error go for now.

@grondo grondo merged commit 2aab88c into flux-framework:master Oct 1, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 4d5ad4b...300982a
Details
codecov/project 76.55% remains the same compared to 4d5ad4b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Oct 1, 2019

Yes, I didn't think it makes sense to reload sched-simple in qmanager's rc3. Thank you for a quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.