Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
rc3: Fix a bug in RC3 dir definition within configure.ac #525
Fix a copy-and-paste error in the rc3 directory definition for qmanager. Without a proper rc3, qmanager wasn't cleanly exited when the Flux instance is torn down: "module 'qmanager' was not cleanly shutdown"
@@ Coverage Diff @@ ## master #525 +/- ## ======================================= Coverage 76.55% 76.55% ======================================= Files 58 58 Lines 6291 6291 ======================================= Hits 4816 4816 Misses 1475 1475
grondo left a comment
LGTM! Tested after
But it would be kind of silly for flux-sched's rc3 script to reload sched-simple in order to work around this error. We need to give better tools in flux-core for this kind of thing.
I think it is ok to just let this error go for now.