Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource graph metadata update #536

Merged
merged 2 commits into from Oct 14, 2019

Conversation

@milroy
Copy link
Member

milroy commented Oct 12, 2019

This PR fixes resource-query output messages and modifies resource_graph_metadata_t.

  • Fixes whitespace and newline characters in resource/utilities/resource-query.cpp

  • Changes the by_path map value to vtx_t in resource/store/resource_graph_store.hpp. A path will never be associated with more than one vertex, so by_path should be map<string, vtx_t>.

milroy added 2 commits Oct 11, 2019
Add a couple of dropped newline characters to clean
up resource-query usage and options message.
Modify resource_graph_metadata_t by_path to
associate a path to a single vtx_t. Previously
this map was general, but it should be restricted
to be many-to-one. Each path maps to exactly
one vertex, but multiple paths can map
to a single vertex.  Multiple paths
to multiple vertices is not a valid
association in a resource graph.
@milroy milroy requested a review from dongahn Oct 12, 2019
@milroy milroy changed the title Graph metadata update Resource graph metadata update Oct 12, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 12, 2019

Codecov Report

Merging #536 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files          69       69           
  Lines        6481     6481           
=======================================
  Hits         4928     4928           
  Misses       1553     1553
Impacted Files Coverage Δ
resource/store/resource_graph_store.hpp 100% <ø> (ø) ⬆️
resource/utilities/resource-query.cpp 50.41% <ø> (ø) ⬆️
resource/readers/resource_reader_grug.cpp 87.81% <100%> (ø) ⬆️
resource/utilities/command.cpp 68.75% <100%> (ø) ⬆️
resource/readers/resource_reader_jgf.cpp 66.26% <100%> (ø) ⬆️
resource/modules/resource_match.cpp 75.67% <100%> (ø) ⬆️
resource/readers/resource_reader_hwloc.cpp 86.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e72c3...6faf810. Read the comment docs.

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Oct 14, 2019

@milroy: This looks great to me. Merging.

@dongahn dongahn merged commit 8342b7d into flux-framework:master Oct 14, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 76.03%)
Details
codecov/project 76.03% (+0%) compared to 16e72c3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.