Fluxbb 1.4 #31

Merged
merged 1 commit into from Mar 30, 2012

Projects

None yet

3 participants

@oldskool
FluxBB member

No description provided.

@oldskool oldskool merged commit 73de7c4 into fluxbb:fluxbb-1.4 Mar 30, 2012
@franzliedke
FluxBB member

I really do wonder why they didn't do it this way originally. Maybe to have an extra layer of synchronization, as the database schema is not properly normalized? But then, really, what could happen that we introduce inconsistencies in the database, eh?

FluxBB member

The change was made when developing 1.2:

http://punbb.informer.com/forums/post/20715/#p20715

Rewrote topic reply counting code to be less error prone. The reply count for a topic is now re-calculated whenever a post is added or removed.

But making the UPDATE query relative to the current value (as this change does) is actually the correct way to do things, assuming every other script similarly keeps data in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment