Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Soule BA to CORE-MAINTAINERS #271

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Add Soule BA to CORE-MAINTAINERS #271

merged 1 commit into from
Dec 15, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Dec 9, 2022

I would like to become a core maintainer.

Signed-off-by: souleb soule@weave.works

@stefanprodan stefanprodan changed the title Update CORE-MAINTAINERS Add Soule BA to CORE-MAINTAINERS Dec 9, 2022
stefanprodan
stefanprodan approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @souleb for all your contributions on Flux. I'm very happy to have you part of the core team 🎉

hiddeco
hiddeco approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continuous efforts and countless contributions @souleb 💯 🙇

@relu
Copy link
Member

relu commented Dec 9, 2022

Amazing work, @souleb, you have my stamp, keep it up! 🙌

makkes
makkes approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks @souleb for all you've done in Flux so far. It's a pleasure working with you. +1

pjbgf
pjbgf approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong +1! Thank you for all the great work, @souleb!

scottrigby
scottrigby approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯👏 nb

phillebaba
phillebaba approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@phillebaba phillebaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hiddeco
Copy link
Member

hiddeco commented Dec 15, 2022

We got all the votes we need, thanks all. If you rebase @souleb, I will do the further due diligence.

@souleb
Update CORE-MAINTAINERS
94aa9c0 
I would like to become a core maintainer.

Signed-off-by: souleb <soule@weave.works>
@hiddeco hiddeco merged commit fa92d68 into fluxcd:main Dec 15, 2022
@souleb souleb deleted the patch-1 branch December 15, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

@scottrigby scottrigby scottrigby approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

@relu relu relu approved these changes

@dholbach dholbach dholbach approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

@pjbgf pjbgf pjbgf approved these changes

@hiddeco hiddeco hiddeco approved these changes

@phillebaba phillebaba phillebaba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@souleb @relu @hiddeco @makkes @scottrigby @darkowlzz @dholbach @stefanprodan @pjbgf @phillebaba