AppMesh: Add annotation to enable Envoy access logs #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
+ Coverage 56.65% 56.75% +0.10%
==========================================
Files 79 79
Lines 6591 6607 +16
==========================================
+ Hits 3734 3750 +16
Misses 2301 2301
Partials 556 556
Continue to review full report at Codecov.
|
| @@ -62,6 +62,9 @@ Create a canary definition: | |||
| apiVersion: flagger.app/v1beta1 | |||
| kind: Canary | |||
| metadata: | |||
| annotations: | |||
| # Enable virtual node logging to stdout. | |||
| "appmesh.flagger.app/accesslog": enabled | |||
There was a problem hiding this comment.
Suggested change
| "appmesh.flagger.app/accesslog": enabled | |
| appmesh.flagger.app/accesslog: enabled |
| @@ -62,6 +62,9 @@ Create a canary definition: | |||
| apiVersion: flagger.app/v1beta1 | |||
| kind: Canary | |||
| metadata: | |||
| annotations: | |||
| # Enable virtual node logging to stdout. | |||
There was a problem hiding this comment.
Suggested change
| # Enable virtual node logging to stdout. | |
| # Enable Envoy access logging to stdout. |
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works> Co-authored-by: wucg <wucg@trip.com>
stefanprodan
changed the title
stefanprodan
added
the
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sanskar Jaiswal sanskar.jaiswal@weave.works
Co-authored-by: wucg wucg@trip.com