Gloo Upstream Ref for Upstream Config #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding with docs updates to supersede #904 |
Codecov Report
@@ Coverage Diff @@
## main #908 +/- ##
==========================================
- Coverage 56.76% 56.66% -0.10%
==========================================
Files 69 69
Lines 5704 5721 +17
==========================================
+ Hits 3238 3242 +4
- Misses 1983 1994 +11
- Partials 483 485 +2
Continue to review full report at Codecov.
|
|
@kdorosh can you please squash all commits? Thanks |
Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> intermediate commit Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> updated gloo unit tests Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> copy config from upstream ref to flagger-generateed upstreams Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> removed unneeded types Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> make fmt Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> added code-generator to replace Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> reverted go.mod Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> fixed struct Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> updated e2es with new upstream ref Signed-off-by: Keerthan Ekbote <keerthan.ekbote@solo.io> Add note to docs about upstreamRef Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io> Fix typo, improve clarity Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>
kdorosh
force-pushed
the
add_gloo_upstreamRef
branch
from
178c483
to
a286625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flagger currently creates upstreams that point to the canary and primary kube services that are generated by flagger. In some use cases, users need additional config to be applied to the created upstreams. This PR allows for an upstreamRef to be specified in the Canary Spec API which points to an already existing Upstream. Flagger will copy the config from this Upstream to the flagger-generated upstreams.